mridulm commented on code in PR #37638: URL: https://github.com/apache/spark/pull/37638#discussion_r1003562799
########## common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java: ########## @@ -593,6 +607,9 @@ public void onData(String streamId, ByteBuffer buf) { @Override public void onComplete(String streamId) { + if (isTooLate) { + pushMergeMetrics.tooLateResponses.mark(); + } Review Comment: That looks like an impl detail in li-2.3.0 branch - any reason not to update this sooner ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org