swamirishi commented on code in PR #38377: URL: https://github.com/apache/spark/pull/38377#discussion_r1003569481
########## core/src/test/scala/org/apache/spark/util/logging/DriverLoggerSuite.scala: ########## @@ -59,15 +60,17 @@ class DriverLoggerSuite extends SparkFunSuite with LocalSparkContext { sc.stop() assert(!driverLogsDir.exists()) - val dfsFile = FileUtils.getFile(sc.getConf.get(DRIVER_LOG_DFS_DIR).get, - app_id + DriverLogger.DRIVER_LOG_FILE_SUFFIX) - assert(dfsFile.exists()) - assert(dfsFile.length() > 0) + val dfsFile = new Path(sc.getConf.get(DRIVER_LOG_DFS_DIR).get + + "/" + app_id + DriverLogger.DRIVER_LOG_FILE_SUFFIX) + val dfsFileStatus = dfsFile.getFileSystem(sc.hadoopConfiguration).getFileStatus(dfsFile) + + assert(dfsFileStatus.isFile) + assert(dfsFileStatus.getLen > 0) } private def getSparkContext(): SparkContext = { val conf = new SparkConf() - conf.set(DRIVER_LOG_DFS_DIR, rootDfsDir.getAbsolutePath()) + conf.set(DRIVER_LOG_DFS_DIR, "file://" + rootDfsDir.getAbsolutePath()) conf.set(DRIVER_LOG_PERSISTTODFS, true) conf.set(SparkLauncher.SPARK_MASTER, "local") Review Comment: Sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org