itholic commented on code in PR #38177:
URL: https://github.com/apache/spark/pull/38177#discussion_r1003966632
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala:
##########
@@ -1124,8 +1124,9 @@ class StringExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
).foreach { case (str: String, format: String) =>
val toNumberExpr = ToNumber(Literal(str), Literal(format))
assert(toNumberExpr.checkInputDataTypes() ==
TypeCheckResult.TypeCheckSuccess)
- checkExceptionInExpression[IllegalArgumentException](
- toNumberExpr, "does not match the given number format")
+
+ checkExceptionInExpression[SparkException](
+ toNumberExpr, "[INTERNAL_ERROR] Undefined error message parameter")
Review Comment:
Seems like I should also fix the test & generated golden files.
Let me fix soon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
