SandishKumarHN commented on code in PR #38344:
URL: https://github.com/apache/spark/pull/38344#discussion_r1004099495
##########
connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/SchemaConverters.scala:
##########
@@ -62,14 +63,18 @@ object SchemaConverters {
case STRING => Some(StringType)
case BYTE_STRING => Some(BinaryType)
case ENUM => Some(StringType)
- case MESSAGE if fd.getMessageType.getName == "Duration" =>
+ case MESSAGE
+ if fd.getMessageType.getName == "Duration" &&
+ fd.getMessageType.getFields.size() == 2 &&
+ fd.getMessageType.getFields.get(0).getName.equals("seconds") &&
+ fd.getMessageType.getFields.get(1).getName.equals("nanos") =>
Some(DayTimeIntervalType.defaultConcreteType)
- case MESSAGE if fd.getMessageType.getName == "Timestamp" =>
- Some(TimestampType)
- // FIXME: Is the above accurate? Users can have protos named
"Timestamp" but are not
- // expected to be TimestampType in Spark. How about verifying
fields?
- // Same for "Duration". Only the Timestamp & Duration protos
defined in
- // google.protobuf package should default to corresponding
Catalylist types.
+ case MESSAGE
+ if fd.getMessageType.getName == "Timestamp" &&
+ fd.getMessageType.getFields.size() == 2 &&
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
