linhongliu-db commented on code in PR #38263:
URL: https://github.com/apache/spark/pull/38263#discussion_r1006308561
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3950,6 +3950,14 @@ object SQLConf {
.checkValues(ErrorMessageFormat.values.map(_.toString))
.createWithDefault(ErrorMessageFormat.PRETTY.toString)
+ val SPARK_MASKING_ALGO = buildConf("spark.sql.masking.algo")
Review Comment:
how about `spark.sql.masking.algo.fipsModeEnabled`
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3950,6 +3950,14 @@ object SQLConf {
.checkValues(ErrorMessageFormat.values.map(_.toString))
.createWithDefault(ErrorMessageFormat.PRETTY.toString)
+ val SPARK_MASKING_ALGO = buildConf("spark.sql.masking.algo")
+ .doc(
+ "This property is used to indicate whether FIPS mode is enabled or not."
+
+ " Value should be sha512 to indicate that FIPS mode is enabled." +
+ "Else the value should be sha256. Using this value column masking is
being done")
+ .version("3.4.0")
+ .stringConf
Review Comment:
let's add `checkValues` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
