amaliujia commented on code in PR #38393:
URL: https://github.com/apache/spark/pull/38393#discussion_r1008513991
##########
python/pyspark/sql/connect/plan.py:
##########
@@ -537,7 +537,7 @@ def __init__(
self,
left: Optional["LogicalPlan"],
right: "LogicalPlan",
- on: "ColumnOrString",
+ on: Optional[Union[str, List[str], ColumnRef]],
Review Comment:
hmmm I gave a try but failed to make it work for mypy and UT together (not a
python expert):
I found the trick case is `str` seems to be also consider-red as `Sequence`
or `Iterable` which have caused things for implementation....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
