amaliujia commented on code in PR #38347:
URL: https://github.com/apache/spark/pull/38347#discussion_r1009828791
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -175,6 +178,28 @@ package object dsl {
}
object plans { // scalastyle:ignore
+ implicit class DslMockRemoteSession(val session: MockRemoteSession) {
+ def range(
+ start: Option[Int],
+ end: Int,
+ step: Option[Int],
+ numPartitions: Option[Int]): Relation = {
+ val range = proto.Range.newBuilder()
Review Comment:
It makes sense for `SparkConnectPlanner` where Catalyst and Proto are both
mixed together, and we are keeping the approach you are asking there.
However this is the Connect DSL that only deal with protos. No Catalyst
included in this package:
https://github.com/apache/spark/blob/9fc3aa0b1c092ab1f13b26582e3ece7440fbfc3b/connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala#L17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
