HyukjinKwon commented on code in PR #38449: URL: https://github.com/apache/spark/pull/38449#discussion_r1009993046
########## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/AlterTableAddPartitionSuite.scala: ########## @@ -124,18 +123,4 @@ class AlterTableAddPartitionSuite checkPartitions(t, Map("id" -> "1"), Map("id" -> "2")) } } - - test("SPARK-40798: Alter partition should verify partition value - legacy") { - withNamespaceAndTable("ns", "tbl") { t => - sql(s"CREATE TABLE $t (c int) $defaultUsing PARTITIONED BY (p int)") - - withSQLConf( - SQLConf.SKIP_TYPE_VALIDATION_ON_ALTER_PARTITION.key -> "true", - SQLConf.ANSI_ENABLED.key -> "false") { Review Comment: Shouldn't we maybe keep the test after removing `SQLConf.ANSI_ENABLED.key -> "false"`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org