mridulm commented on code in PR #38371: URL: https://github.com/apache/spark/pull/38371#discussion_r1010007062
########## core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala: ########## @@ -3089,13 +3089,14 @@ class DAGSchedulerSuite extends SparkFunSuite with TempLocalSparkContext with Ti submit(finalRdd, Array(0, 1), properties = new Properties()) // Finish the first 2 shuffle map stages. - completeShuffleMapStageSuccessfully(0, 0, 2) + completeShuffleMapStageSuccessfully(0, 0, 2, Seq("hostA", "hostB")) Review Comment: Enhancing documentation of `completeShuffleMapStageSuccessfully` is sufficient - we dont want to explicitly specify `hostNames` for all invocations of the method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org