MaxGekk commented on code in PR #38448:
URL: https://github.com/apache/spark/pull/38448#discussion_r1010108090
##########
sql/core/src/test/resources/sql-tests/results/literals.sql.out:
##########
@@ -442,9 +442,10 @@ struct<>
-- !query output
org.apache.spark.sql.catalyst.parser.ParseException
{
- "errorClass" : "_LEGACY_ERROR_TEMP_0021",
+ "errorClass" : "UNSUPPORTED_TYPED_LITERAL",
"messageParameters" : {
- "valueType" : "GEO"
+ "supportedTypes" : "\"DATE\", \"TIMESTAMP_NTZ\", \"TIMESTAMP_LTZ\",
\"TIMESTAMP\", \"INTERVAL\", \"X\"",
Review Comment:
It depends on implementation, and we might support more in the future.
Having the list in the source code can give the following benefits:
1. The list of parameters might be formatted in different ways ( as a
foldable or drop-down list) by frontend tools.
2. More likely, devs will not forget to update the list in source code.
3. If the list will be in the JSON file, tech editors might forget to edit
it or accidentally modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
