HyukjinKwon commented on code in PR #38485: URL: https://github.com/apache/spark/pull/38485#discussion_r1012492270
########## python/pyspark/sql/connect/client.py: ########## @@ -42,6 +43,125 @@ logging.basicConfig(level=logging.INFO) +class ChannelBuilder: + """ + This is a helper class that is used to create a GRPC channel based on the given + connection string per the documentation of Spark Connect. Review Comment: For a user-facing API (or developer API), it should better have a complete docs like including `Examples` section. I am fine without this too if that's tricky to add for now. Also, would need to add `versionadded` directive in the docstring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
