vinodkc commented on code in PR #38146: URL: https://github.com/apache/spark/pull/38146#discussion_r1013413707
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala: ########## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions + +import org.apache.spark.sql.catalyst.expressions.codegen._ +import org.apache.spark.sql.types.{AbstractDataType, DataType, StringType} +import org.apache.spark.unsafe.types.UTF8String + +// scalastyle:off line.size.limit +@ExpressionDescription( + usage = + """_FUNC_(input[, upperChar, lowerChar, digitChar, otherChar]) - masks the given string value""", + arguments = """ + Arguments: + * input - string value to mask. Supported types: STRING, VARCHAR, CHAR + * upperChar - character to replace upper-case characters with. Specify -1 to retain original character. Default value: 'X' + * lowerChar - character to replace lower-case characters with. Specify -1 to retain original character. Default value: 'x' + * digitChar - character to replace digit characters with. Specify -1 to retain original character. Default value: 'n' + * otherChar - character to replace all other characters with. Specify -1 to retain original character. Default value: -1 + """, + examples = """ + Examples: + > SELECT _FUNC_('abcd-EFGH-8765-4321'); + xxxx-XXXX-nnnn-nnnn + > SELECT _FUNC_('abcd-EFGH-8765-4321', 'Q'); + xxxx-QQQQ-nnnn-nnnn + > SELECT _FUNC_('AbCD123-@$#', 'Q','q'); + QqQQnnn-@$# + > SELECT _FUNC_('AbCD123-@$#'); + XxXXnnn-@$# + > SELECT _FUNC_('AbCD123-@$#', 'Q'); + QxQQnnn-@$# + > SELECT _FUNC_('AbCD123-@$#', 'Q','q'); + QqQQnnn-@$# + > SELECT _FUNC_('AbCD123-@$#', 'Q','q', 'd'); + QqQQddd-@$# + > SELECT _FUNC_('AbCD123-@$#', 'Q','q', 'd', 'o'); + QqQQdddoooo + > SELECT _FUNC_('AbCD123-@$#', -1, 'q', 'd', 'o'); + AqCDdddoooo + > SELECT _FUNC_('AbCD123-@$#', -1,-1, 'd', 'o'); + AbCDdddoooo + > SELECT _FUNC_('AbCD123-@$#', -1,-1, -1, 'o'); + AbCD123oooo + > SELECT _FUNC_(NULL, -1,-1, -1, 'o'); Review Comment: Added test cases where replacement characters are NULL, it will throw an analysis exception -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org