HyukjinKwon commented on code in PR #38468:
URL: https://github.com/apache/spark/pull/38468#discussion_r1013555606
##########
python/pyspark/sql/connect/client.py:
##########
@@ -182,6 +191,10 @@ def _to_pandas(self, plan: pb2.Plan) ->
Optional[pandas.DataFrame]:
req = pb2.Request()
req.user_context.user_id = self._user_id
req.plan.CopyFrom(plan)
+ if self.has_arrow:
+ req.preferred_result_type = pb2.Request.ArrowBatch
+ else:
+ req.preferred_result_type = pb2.Request.JSONBatch
Review Comment:
We could remove this and just let it throw an exception. I think we can just
make the Arrow as a hard requirement. Since this is a new code not released
yet, let's go with a stricter approach. cc @grundprinzip FYI.
We can remove this in a separate PR too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
