itholic commented on code in PR #38569: URL: https://github.com/apache/spark/pull/38569#discussion_r1017351734
########## core/src/main/resources/error/error-classes.json: ########## @@ -469,6 +469,11 @@ "Grouping sets size cannot be greater than <maxSize>" ] }, + "GROUP_BY_AGGREGATE" : { Review Comment: I'm not pretty sure since `GROUP_BY_POS_REFERS_AGG_EXPR` requires `<index>`, but `GROUP_BY_AGGREGATE ` only cares if the aggregate function is used in the group by cause. We can manually pass the missing value for `<index>`, but not sure it makes sense or not. WDYT, @srielau @MaxGekk ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org