pan3793 commented on code in PR #38596:
URL: https://github.com/apache/spark/pull/38596#discussion_r1018684836
##########
pom.xml:
##########
@@ -928,16 +924,6 @@
<version>${netty.version}</version>
<classifier>osx-x86_64</classifier>
</dependency>
- <!-- SPARK-38541: Add the explicit dependency on
`netty-tcnative-classes` because the dependency on
- `netty-tcnative-classes` is changed to `Optional` in
[netty](https://github.com/netty/netty/pull/12146).
- `netty-tcnative-classes` module is mainly used by SSL package in
`netty-handler`.
Review Comment:
Netty support openSSL and JDK SSL, to enable openSSL support,
`netty-tcnative-classes` and [platform native
libs](https://repo1.maven.org/maven2/io/netty/netty-tcnative-boringssl-static/2.0.54.Final/)
should be existed in classpath.
Single `netty-tcnative-classes` will cause
https://github.com/netty/netty/issues/12101
And previous `netty-all`(fat jar) does not include tcnative as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
