MaxGekk commented on code in PR #38588:
URL: https://github.com/apache/spark/pull/38588#discussion_r1018726135
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -2109,11 +2103,6 @@
"Unsupported component type <clz> in arrays."
]
},
- "_LEGACY_ERROR_TEMP_1104" : {
- "message" : [
- "The second argument should be a double literal."
Review Comment:
In the fact, the expression must be a literal (foldable I think), and we can
throw `DATATYPE_MISMATCH.NON_FOLDABLE_INPUT`. And then check that it is a
double or a decimal (throw `DATATYPE_MISMATCH.UNEXPECTED_INPUT_TYPE`.
And one more thing, the entire checking logic should be moved to
`checkInputDataTypes` instead of checking in a constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
