cloud-fan commented on code in PR #38404: URL: https://github.com/apache/spark/pull/38404#discussion_r1019781125
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ########## @@ -288,6 +289,11 @@ class AstBuilder extends SqlBaseParserBaseVisitor[AnyRef] with SQLConfHelper wit query, overwrite = true, ifPartitionNotExists) + case ctx: InsertIntoReplaceWhereContext => Review Comment: I think we should fail if `identifierList` is specified. I'll update `OverwriteByExpression` to support column list later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org