HyukjinKwon commented on code in PR #38613:
URL: https://github.com/apache/spark/pull/38613#discussion_r1019831985
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamHandler.scala:
##########
@@ -184,9 +158,30 @@ class SparkConnectStreamHandler(responseObserver:
StreamObserver[Response]) exte
responseObserver.onNext(response.build())
numSent += 1
}
+ }
+
+ // Store collection results for worst case of 1 to N-1 partitions
+ val results = new Array[Array[Batch]](numPartitions - 1)
+ var lastIndex = -1 // index of last partition written
- currentPartitionId += 1
+ // Handler to eagerly write partitions in order
+ val resultHandler = (partitionId: Int, partition: Array[Batch]) => {
Review Comment:
Nope, it doesn't (because it's guided by the index). This approach is
actually from the initial ordered implementation of collect with Arrow (that
has been running in production for very long time),
https://github.com/apache/spark/commit/82c18c240a6913a917df3b55cc5e22649561c4dd#diff-459628811d7786c705fbb2b7a381ecd2b88f183f44ab607d43b3d33ea48d390fR3282-R3318.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
