rangadi commented on code in PR #38603:
URL: https://github.com/apache/spark/pull/38603#discussion_r1019851951
##########
python/pyspark/sql/protobuf/functions.py:
##########
@@ -32,7 +32,7 @@
def from_protobuf(
data: "ColumnOrName",
messageName: str,
- descFilePath: str,
+ descFilePath: Optional[str] = None,
Review Comment:
Update documentation to reflect change in contract.
@HyukjinKwon is it common to use Optional[] for optional arguments in
PySpark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
