pan3793 opened a new pull request, #38622:
URL: https://github.com/apache/spark/pull/38622

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: 
https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a 
faster review.
     7. If you want to add a new configuration, please read the guideline first 
for naming configurations in
        
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the 
guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section 
is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster 
reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class 
hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other 
DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   Treating container `AllocationFailure` as not "exitCausedByApp" when driver 
is shutting down.
   
   The approach is suggested at 
https://github.com/apache/spark/pull/36991#discussion_r915948343
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   I observed some Spark Applications successfully completed all jobs but 
failed during the shutting down phase w/ reason: Max number of executor 
failures (16) reached, the timeline is
   
   Driver - Job success, Spark starts shutting down procedure.
   ```
   2022-06-23 19:50:55 CST AbstractConnector INFO - Stopped 
Spark@74e9431b{HTTP/1.1, (http/1.1)}{0.0.0.0:0}
   2022-06-23 19:50:55 CST SparkUI INFO - Stopped Spark web UI at 
http://hadoop2627.xxx.org:28446
   2022-06-23 19:50:55 CST YarnClusterSchedulerBackend INFO - Shutting down all 
executors
   ```
   
   Driver - A container allocate successful during shutting down phase.
   ```
   2022-06-23 19:52:21 CST YarnAllocator INFO - Launching container 
container_e94_1649986670278_7743380_02_000025 on host hadoop4388.xxx.org for 
executor with ID 24 for ResourceProfile Id 0
   ```
   
   Executor - The executor can not connect to driver endpoint because driver 
already stopped the endpoint.
   ```
   Exception in thread "main" java.lang.reflect.UndeclaredThrowableException
     at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1911)
     at 
org.apache.spark.deploy.SparkHadoopUtil.runAsSparkUser(SparkHadoopUtil.scala:61)
     at 
org.apache.spark.executor.CoarseGrainedExecutorBackend$.run(CoarseGrainedExecutorBackend.scala:393)
     at 
org.apache.spark.executor.YarnCoarseGrainedExecutorBackend$.main(YarnCoarseGrainedExecutorBackend.scala:81)
     at 
org.apache.spark.executor.YarnCoarseGrainedExecutorBackend.main(YarnCoarseGrainedExecutorBackend.scala)
   Caused by: org.apache.spark.SparkException: Exception thrown in awaitResult: 
     at org.apache.spark.util.ThreadUtils$.awaitResult(ThreadUtils.scala:301)
     at org.apache.spark.rpc.RpcTimeout.awaitResult(RpcTimeout.scala:75)
     at org.apache.spark.rpc.RpcEnv.setupEndpointRefByURI(RpcEnv.scala:101)
     at 
org.apache.spark.executor.CoarseGrainedExecutorBackend$.$anonfun$run$9(CoarseGrainedExecutorBackend.scala:413)
     at scala.runtime.java8.JFunction1$mcVI$sp.apply(JFunction1$mcVI$sp.java:23)
     at 
scala.collection.TraversableLike$WithFilter.$anonfun$foreach$1(TraversableLike.scala:877)
     at scala.collection.immutable.Range.foreach(Range.scala:158)
     at 
scala.collection.TraversableLike$WithFilter.foreach(TraversableLike.scala:876)
     at 
org.apache.spark.executor.CoarseGrainedExecutorBackend$.$anonfun$run$7(CoarseGrainedExecutorBackend.scala:411)
     at 
org.apache.spark.deploy.SparkHadoopUtil$$anon$1.run(SparkHadoopUtil.scala:62)
     at 
org.apache.spark.deploy.SparkHadoopUtil$$anon$1.run(SparkHadoopUtil.scala:61)
     at java.security.AccessController.doPrivileged(Native Method)
     at javax.security.auth.Subject.doAs(Subject.java:422)
     at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1893)
     ... 4 more
   Caused by: org.apache.spark.rpc.RpcEndpointNotFoundException: Cannot find 
endpoint: spark://coarsegrainedschedu...@hadoop2627.xxx.org:21956
     at 
org.apache.spark.rpc.netty.NettyRpcEnv.$anonfun$asyncSetupEndpointRefByURI$1(NettyRpcEnv.scala:148)
     at 
org.apache.spark.rpc.netty.NettyRpcEnv.$anonfun$asyncSetupEndpointRefByURI$1$adapted(NettyRpcEnv.scala:144)
     at scala.concurrent.Future.$anonfun$flatMap$1(Future.scala:307)
     at scala.concurrent.impl.Promise.$anonfun$transformWith$1(Promise.scala:41)
     at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:64)
     at org.apache.spark.util.ThreadUtils$$anon$1.execute(ThreadUtils.scala:99)
     at 
scala.concurrent.impl.ExecutionContextImpl$$anon$4.execute(ExecutionContextImpl.scala:138)
     at 
scala.concurrent.impl.CallbackRunnable.executeWithValue(Promise.scala:72)
     at 
scala.concurrent.impl.Promise$DefaultPromise.$anonfun$tryComplete$1(Promise.scala:288)
     at 
scala.concurrent.impl.Promise$DefaultPromise.$anonfun$tryComplete$1$adapted(Promise.scala:288)
     at 
scala.concurrent.impl.Promise$DefaultPromise.tryComplete(Promise.scala:288)
   ```
   
   Driver - YarnAllocator received container launch error message and treat it 
as `exitCausedByApp`
   ```
   2022-06-23 19:52:27 CST YarnAllocator INFO - Completed container 
container_e94_1649986670278_7743380_02_000025 on host: hadoop4388.xxx.org 
(state: COMPLETE, exit status: 1)
   2022-06-23 19:52:27 CST YarnAllocator WARN - Container from a bad node: 
container_e94_1649986670278_7743380_02_000025 on host: hadoop4388.xxx.org. Exit 
status: 1. Diagnostics: [2022-06-23 19:52:24.932]Exception from 
container-launch.
   Container id: container_e94_1649986670278_7743380_02_000025
   Exit code: 1
   Shell output: main : command provided 1
   main : run as user is bdms_pm
   main : requested yarn user is bdms_pm
   Getting exit code file...
   Creating script paths...
   Writing pid file...
   Writing to tmp file 
/mnt/dfs/2/yarn/local/nmPrivate/application_1649986670278_7743380/container_e94_1649986670278_7743380_02_000025/container_e94_1649986670278_7743380_02_000025.pid.tmp
   Writing to cgroup task files...
   Creating local dirs...
   Launching container...
   Getting exit code file...
   Creating script paths...
   
   
   [2022-06-23 19:52:24.938]Container exited with a non-zero exit code 1. Error 
file: prelaunch.err.
   Last 4096 bytes of prelaunch.err :
   Last 4096 bytes of stderr :
   at 
scala.concurrent.Future$InternalCallbackExecutor$.execute(Future.scala:873)
     at 
scala.concurrent.impl.CallbackRunnable.executeWithValue(Promise.scala:72)
     at 
scala.concurrent.impl.Promise$DefaultPromise.$anonfun$tryComplete$1(Promise.scala:288)
     at 
scala.concurrent.impl.Promise$DefaultPromise.$anonfun$tryComplete$1$adapted(Promise.scala:288)
     at 
scala.concurrent.impl.Promise$DefaultPromise.tryComplete(Promise.scala:288)
     at scala.concurrent.Promise.trySuccess(Promise.scala:94)
     at scala.concurrent.Promise.trySuccess$(Promise.scala:94)
     at 
scala.concurrent.impl.Promise$DefaultPromise.trySuccess(Promise.scala:187)
     at 
org.apache.spark.rpc.netty.NettyRpcEnv.onSuccess$1(NettyRpcEnv.scala:225)
     at 
org.apache.spark.rpc.netty.NettyRpcEnv.$anonfun$askAbortable$7(NettyRpcEnv.scala:246)
     at 
org.apache.spark.rpc.netty.NettyRpcEnv.$anonfun$askAbortable$7$adapted(NettyRpcEnv.scala:246)
     at org.apache.spark.rpc.netty.RpcOutboxMessage.onSuccess(Outbox.scala:90)
     at 
org.apache.spark.network.client.TransportResponseHandler.handle(TransportResponseHandler.java:195)
     at 
org.apache.spark.network.server.TransportChannelHandler.channelRead0(TransportChannelHandler.java:142)
     at 
org.apache.spark.network.server.TransportChannelHandler.channelRead0(TransportChannelHandler.java:53)
     at 
io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99)
     at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
     at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
   ```
   
   Driver - Eventually application failed because ”failed“ executor reached 
threshold 
   ```
   2022-06-23 19:52:30 CST ApplicationMaster INFO - Final app status: FAILED, 
exitCode: 11, (reason: Max number of executor failures (16) reached)
   ```
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as 
the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes 
- provide the console output, description and/or an example to show the 
behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to 
the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions 
for the consistent environment, and the instructions could accord to: 
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   Update UT.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to