grundprinzip commented on code in PR #38631:
URL: https://github.com/apache/spark/pull/38631#discussion_r1020565080
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -334,7 +334,11 @@ class SparkConnectPlanner(session: SparkSession) {
}
private def transformAlias(alias: proto.Expression.Alias): NamedExpression =
{
- Alias(transformExpression(alias.getExpr), alias.getName)()
+ if (alias.getNameCount == 1) {
+ Alias(transformExpression(alias.getExpr), alias.getName(0))()
+ } else {
+ MultiAlias(transformExpression(alias.getExpr),
alias.getNameList.asScala.toSeq)
Review Comment:
I understand the concepts of the DSL and the testing (I was there when it
was written), but thanks a lot for the detailed explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
