cloud-fan commented on code in PR #38495: URL: https://github.com/apache/spark/pull/38495#discussion_r1022525354
########## sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala: ########## @@ -609,6 +609,17 @@ private[hive] class HiveClientImpl( shim.alterTable(client, qualifiedTableName, hiveTable) } + override def alterTableProps( + dbName: String, + tableName: String, + newProps: Map[String, String]): Unit = withHiveState { + val hiveTable = getRawHiveTable(dbName, tableName).rawTable.asInstanceOf[HiveTable] Review Comment: This method should take `RawHiveTable`, so that we don't need to look up the table here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org