Github user harishreedharan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6166#discussion_r30535433
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsTab.scala 
---
    @@ -73,6 +73,16 @@ class ExecutorsListener(storageStatusListener: 
StorageStatusListener) extends Sp
         uiData.finishReason = Some(executorRemoved.reason)
       }
     
    +  override def onApplicationStart(applicationStart: 
SparkListenerApplicationStart): Unit = {
    +    applicationStart.driverLogs.foreach { logs =>
    +      val storageStatus = storageStatusList.find { s =>
    +        s.blockManagerId.executorId == 
SparkContext.LEGACY_DRIVER_IDENTIFIER ||
    +        s.blockManagerId.executorId == SparkContext.DRIVER_IDENTIFIER
    +      }
    +      storageStatus.foreach { s => 
executorToLogUrls(s.blockManagerId.executorId) = logs.toMap }
    --- End diff --
    
    Do you want me to change it in `JsonProtocol`? I think it is fine here in 
this case, since this is where we are using it (unlike in the other case, where 
it needs to go into an `ExecutorInfo`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to