grundprinzip commented on code in PR #38723: URL: https://github.com/apache/spark/pull/38723#discussion_r1027288544
########## python/pyspark/sql/connect/dataframe.py: ########## @@ -124,6 +125,29 @@ def withPlan(cls, plan: plan.LogicalPlan, session: "RemoteSparkSession") -> "Dat def select(self, *cols: "ExpressionOrString") -> "DataFrame": return DataFrame.withPlan(plan.Project(self._plan, *cols), session=self._session) + def selectExpr(self, *expr: Union[str, List[str]]) -> "DataFrame": + """Projects a set of SQL expressions and returns a new :class:`DataFrame`. + + This is a variant of :func:`select` that accepts SQL expressions. + + .. versionadded:: 3.4.0 + + Returns + ------- + :class:`DataFrame` + A DataFrame with new/old columns transformed by expressions. + """ + sql_expr = [] + if len(expr) == 1 and isinstance(expr[0], list): + expr = expr[0] # type: ignore[assignment] + for element in expr: + if isinstance(element, str): + sql_expr.append(SQLExpression(element)) + else: + sql_expr.extend([SQLExpression(e) for e in element]) + + return DataFrame.withPlan(plan.Project(self._plan, *sql_expr), session=self._session) Review Comment: This was not necessarily the question that I had, but I was not remembering correctly the type interface to Project: ``` def __init__(self, child: Optional["LogicalPlan"], *columns: "ExpressionOrString") -> None: ``` In this case `SQLExpression` is an expression and it just works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org