itholic commented on code in PR #38728: URL: https://github.com/apache/spark/pull/38728#discussion_r1027408367
########## connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ########## @@ -45,12 +46,18 @@ import org.apache.spark.util.Utils final case class InvalidPlanInput( private val message: String = "", private val cause: Throwable = None.orNull) - extends Exception(message, cause) + extends SparkException( Review Comment: Can we have test for the exception ?? If it's already exists, let's convert the existing test to use `checkError` to check error class and parameters generated properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org