cloud-fan commented on code in PR #38747:
URL: https://github.com/apache/spark/pull/38747#discussion_r1028740897
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala:
##########
@@ -121,7 +121,11 @@ object SQLExecution {
SparkThrowableHelper.getMessage(e)
}
val event = SparkListenerSQLExecutionEnd(
- executionId, System.currentTimeMillis(), errorMessage)
+ executionId,
+ System.currentTimeMillis(),
+ // Use empty string to indicate no error, as None may mean events
generated by old
+ // versions of Spark.
+ errorMessage.orElse(Some("")))
Review Comment:
good point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
