cloud-fan commented on code in PR #38739: URL: https://github.com/apache/spark/pull/38739#discussion_r1028793298
########## sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala: ########## @@ -3532,6 +3532,49 @@ class DataFrameSuite extends QueryTest }.isEmpty) } } + + test("SPARK-41207: Fix BinaryArithmetic with negative scale") { + withSQLConf(SQLConf.LEGACY_ALLOW_NEGATIVE_SCALE_OF_DECIMAL_ENABLED.key -> "true") { Review Comment: I'm not sure this fixes all issues. Officially supporting negative scale is really a hard problem. Do you really turn on this config in production? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org