[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38567: [SPARK-41054][UI][CORE] Support RocksDB as KVStore in live UI

Wed, 23 Nov 2022 12:30:06 -0800 


dongjoon-hyun commented on code in PR #38567:
URL: https://github.com/apache/spark/pull/38567#discussion_r1030848858


##########
core/src/main/scala/org/apache/spark/status/AppStatusStore.scala:
##########
@@ -769,7 +772,12 @@ private[spark] object AppStatusStore {
   def createLiveStore(
       conf: SparkConf,
       appStatusSource: Option[AppStatusSource] = None): AppStatusStore = {
-    val store = new ElementTrackingStore(new InMemoryStore(), conf)
+    val storePath = conf.get(LIVE_UI_LOCAL_STORE_DIR).map(new File(_))
+    // For the disk-based KV store of live UI, let's simply make it ROCKSDB 
only for now,
+    // instead of supporting both LevelDB and RocksDB. RocksDB is built based 
on LevelDB with

Review Comment:
   According to the context, Reynold mentioned that the legal issue was 
resolved. Do you mean that Apache Spark still have legal issue with RocksDB, 
@gengliangwang ?
   
   ![Screenshot 2022-11-23 at 12 28 24 
PM](https://user-images.githubusercontent.com/9700541/203640432-10e7af59-ccb1-4bf3-811b-1b4b606410b4.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to