dengziming commented on code in PR #38838:
URL: https://github.com/apache/spark/pull/38838#discussion_r1035752572
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -360,13 +360,8 @@ class SparkConnectPlanner(session: SparkSession) {
} else {
logical.OneRowRelation()
}
- // TODO: support the target field for *.
val projection =
- if (rel.getExpressionsCount == 1 &&
rel.getExpressions(0).hasUnresolvedStar) {
- Seq(UnresolvedStar(Option.empty))
- } else {
-
rel.getExpressionsList.asScala.map(transformExpression).map(UnresolvedAlias(_))
- }
+
rel.getExpressionsList.asScala.map(transformExpression).map(UnresolvedAlias(_))
Review Comment:
Thank you for your review @cloud-fan @amaliujia , I have added one test case
for it, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
