srielau commented on code in PR #38728:
URL: https://github.com/apache/spark/pull/38728#discussion_r1036118316


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -132,7 +132,97 @@
       },
       "INTERCEPTOR_RUNTIME_ERROR" : {
         "message" : [
-          "Error instantiating GRPC interceptor: <msg>"
+          "Error instantiating GRPC interceptor: <msg>."
+        ]
+      },
+      "INVALID_COMMAND_WRITE_INVALID_BUCKET_BY" : {
+        "message" : [
+          "BucketBy must specify a bucket count > 0, received <bucket> 
instead."
+        ]
+      },
+      "INVALID_PLAN_DEDUPLICATE_INVALID_INPUT" : {
+        "message" : [
+          "Deduplicate must be called with either all or a subset of column 
names to deduplicate."
+        ]
+      },
+      "INVALID_PLAN_DEDUPLICATE_INVALID_INPUT_COLUMN" : {
+        "message" : [
+          "Invalid column name used for Deduplicate: <col>."
+        ]
+      },
+      "INVALID_PLAN_EMPTY_INPUT" : {
+        "message" : [
+          "Input relation must not be empty."
+        ]
+      },
+      "INVALID_PLAN_INPUT" : {
+        "message" : [
+          "Error transforming Spark Connect plan: <msg>."
+        ]
+      },
+      "INVALID_PLAN_INVALID_ALIAS" : {
+        "message" : [
+          "Alias expressions with more than 1 identifier must not use optional 
metadata."
+        ]
+      },
+      "INVALID_PLAN_INVALID_DATA_SOURCE" : {
+        "message" : [
+          "Read from DataSource requires a format parameter."
+        ]
+      },
+      "INVALID_PLAN_INVALID_JOIN_CONDITION" : {
+        "message" : [
+          "Using columns or join conditions cannot be set at the same time in 
Join."
+        ]
+      },
+      "INVALID_PLAN_INVALID_SET_OPERATION" : {
+        "message" : [
+          "Invalid Set operation: <type> does not support <param>."
+        ]
+      },
+      "INVALID_PLAN_TRANSFORM_NA_FILL_EMPTY" : {

Review Comment:
   Uhm, I'm now no smarter. The real question is: Will users know what to do 
with this error?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to