cloud-fan commented on code in PR #38777: URL: https://github.com/apache/spark/pull/38777#discussion_r1036655896
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala: ########## @@ -272,7 +273,7 @@ object FileSourceStrategy extends Strategy with PredicateHelper with Logging { case FileFormat.ROW_INDEX => fileFormatReaderGeneratedMetadataColumns .find(_.name == FileFormat.ROW_INDEX_TEMPORARY_COLUMN_NAME) - .get.withName(FileFormat.ROW_INDEX) + .get.withName(FileFormat.ROW_INDEX).withNullability(false) Review Comment: can we add a code comment to explain this nullability change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org