LuciferYang commented on code in PR #38874: URL: https://github.com/apache/spark/pull/38874#discussion_r1039215759
########## sql/core/src/test/resources/sql-tests/inputs/array.sql: ########## @@ -119,3 +119,21 @@ select get(array(1, 2, 3), 0); select get(array(1, 2, 3), 3); select get(array(1, 2, 3), null); select get(array(1, 2, 3), -1); + +-- function array_compact +select Review Comment: I think we should change this case to one corresponding to ``` val invalid_datatype_df = Seq(1, 2, 3).toDF("a") ``` others is ok to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org