Ngone51 commented on code in PR #38901:
URL: https://github.com/apache/spark/pull/38901#discussion_r1039732976
##########
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala:
##########
@@ -85,7 +85,19 @@ private[spark] class CoarseGrainedExecutorBackend(
logInfo("Connecting to driver: " + driverUrl)
try {
- if (PlatformDependent.directBufferPreferred() &&
+ // The following logic originally comes from the constructor of
+ // org.apache.spark.network.client.TransportClientFactory
+ val sharedByteBufAllocators =
+ env.conf.getBoolean("spark.network.sharedByteBufAllocators.enabled",
true)
+ val preferDirectBufsForSharedByteBufAllocators =
+ env.conf.getBoolean("spark.network.io.preferDirectBufs", true)
+ val preferDirectBufs =
+ env.conf.getBoolean("spark.shuffle.io.preferDirectBufs", true)
Review Comment:
Why should we limit the condition to the spark confs too? I think Netty
would still use the direct buffers even if spark preferDirectBufs=false as long
as PlatformDependent.directBufferPreferred()=true, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
