[GitHub] [spark] MaxGekk commented on a diff in pull request #38972: [SPARK-41443][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1061

[GitBox]

MaxGekk commented on code in PR #38972:
URL: https://github.com/apache/spark/pull/38972#discussion_r1043303522


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -109,6 +109,11 @@
       "The column <columnName> already exists. Consider to choose another name 
or rename the existing column."
     ]
   },
+  "COLUMN_NOT_EXISTS" : {

Review Comment:
   How about `COLUMN_NOT_FOUND`. This is more consistent to other error classes:
   ```
   $ grep NOT_FOUND ./core/src/main/resources/error/error-classes.json
     "FIELD_NOT_FOUND" : {
     "INDEX_NOT_FOUND" : {
     "PARTITIONS_NOT_FOUND" : {
     "PATH_NOT_FOUND" : {
     "PROTOBUF_DEPENDENCY_NOT_FOUND" : {
     "PROTOBUF_DESCRIPTOR_FILE_NOT_FOUND" : {
     "PROTOBUF_MESSAGE_NOT_FOUND" : {
     "RENAME_SRC_PATH_NOT_FOUND" : {
     "ROUTINE_NOT_FOUND" : {
     "SCHEMA_NOT_FOUND" : {
     "TABLE_OR_VIEW_NOT_FOUND" : {
         "CORRELATED_COLUMN_NOT_FOUND" : {
     "VIEW_NOT_FOUND" : {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org