dongjoon-hyun commented on code in PR #39004: URL: https://github.com/apache/spark/pull/39004#discussion_r1044325535
########## scalastyle-config.xml: ########## @@ -135,9 +135,9 @@ This file is divided into 3 sections: <!-- ??? usually shouldn't be checked into the code base. --> <check level="error" class="org.scalastyle.scalariform.NotImplementedErrorUsage" enabled="true"></check> - <!-- As of SPARK-7558, all tests in Spark should extend o.a.s.SparkFunSuite instead of FunSuite directly --> + <!-- As of SPARK-7558, all tests in Spark should extend o.a.s.SparkFunSuite instead of AnyFunSuite directly --> <check customId="funsuite" level="error" class="org.scalastyle.scalariform.TokenChecker" enabled="true"> - <parameters><parameter name="regex">^FunSuite[A-Za-z]*$</parameter></parameters> + <parameters><parameter name="regex">^AnyFunSuite[A-Za-z]*$</parameter></parameters> Review Comment: We need to detect both `FunSuite` and `AnyFunSuite` from new your PRs, don't we? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
