dongjoon-hyun commented on code in PR #38993: URL: https://github.com/apache/spark/pull/38993#discussion_r1045023941
########## sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/LogDivertAppender.java: ########## @@ -276,12 +276,19 @@ private static StringLayout initLayout(OperationLog.LoggingLevel loggingMode) { return getLayout(isVerbose, layout); } - public LogDivertAppender(OperationManager operationManager, - OperationLog.LoggingLevel loggingMode) { + public static LogDivertAppender create(OperationManager operationManager, + OperationLog.LoggingLevel loggingMode) { + CharArrayWriter writer = new CharArrayWriter(); + return new LogDivertAppender(operationManager, loggingMode, writer); + } + + private LogDivertAppender(OperationManager operationManager, + OperationLog.LoggingLevel loggingMode, CharArrayWriter writer) { Review Comment: Two more spaces like before? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org