LuciferYang commented on code in PR #38874: URL: https://github.com/apache/spark/pull/38874#discussion_r1046749466
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala: ########## @@ -4600,3 +4600,40 @@ case class ArrayExcept(left: Expression, right: Expression) extends ArrayBinaryL override protected def withNewChildrenInternal( newLeft: Expression, newRight: Expression): ArrayExcept = copy(left = newLeft, right = newRight) } + +@ExpressionDescription( + usage = "_FUNC_(array) - Removes null values from the array.", + examples = """ + Examples: + > SELECT _FUNC_(array(1, 2, 3, null)); + [1,2,3] + """, + group = "array_funcs", + since = "3.4.0") +case class ArrayCompact(expr: Expression, replacement: Expression) + extends RuntimeReplaceable with InheritAnalysisRules { + + def this(expr: Expression) = this(expr, + ArrayFilter(expr, ArrayCompact.createLamdbaExpr())) + + override def parameters: Seq[Expression] = Seq.empty + + override def prettyName: String = "array_compact" + + override protected def withNewChildInternal(newChild: Expression): ArrayCompact = + copy(replacement = newChild) +} + +object ArrayCompact { + + def apply(expr: Expression) = { Review Comment: public member need type annotation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org