thejdeep commented on code in PR #36165:
URL: https://github.com/apache/spark/pull/36165#discussion_r1054375191
##########
core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala:
##########
@@ -1653,7 +1663,19 @@ private[spark] object JsonProtocolSuite extends
Assertions {
| "Remote Bytes Read": 1000,
| "Remote Bytes Read To Disk": 400,
| "Local Bytes Read": 1100,
- | "Total Records Read": 10
+ | "Total Records Read": 10,
+ | "Remote Requests Duration": 900,
+ | "Push Based Shuffle": {
+ | "Corrupt Merged Block Chunks" : 100,
+ | "Merged Fetch Fallback Count" : 100,
+ | "Merged Remote Blocks Fetched" : 0,
+ | "Merged Local Blocks Fetched" : 0,
+ | "Merged Remote Chunks Fetched" : 0,
+ | "Merged Local Chunks Fetched" : 0,
+ | "Merged Remote Bytes Read" : 0,
+ | "Merged Local Bytes Read" : 0,
+ | "Merged Remote Requests Duration": 900
Review Comment:
This is [currently being
set](https://github.com/apache/spark/blob/e46031651617393bb182e44ae04920d6c89592f6/core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala#L1315)
to `executorDeserializeTime` + `jvmGCTime` while making the test task metrics,
do you think that assumption is incorrect ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
