[GitHub] [spark] LuciferYang commented on a diff in pull request #39215: [SPARK-41709][CORE][SQL][UI] Explicitly define `Seq` as `collection.Seq` to avoid `toSeq` when create ui objects from protobuf objects for Scala 2.13

[GitBox]

LuciferYang commented on code in PR #39215:
URL: https://github.com/apache/spark/pull/39215#discussion_r1057167898


##########
core/src/main/scala/org/apache/spark/status/api/v1/api.scala:
##########
@@ -461,7 +461,7 @@ class ApplicationEnvironmentInfo private[spark] (
     val systemProperties: Seq[(String, String)],
     val metricsProperties: Seq[(String, String)],
     val classpathEntries: Seq[(String, String)],
-    val resourceProfiles: Seq[ResourceProfileInfo])
+    val resourceProfiles: collection.Seq[ResourceProfileInfo])

Review Comment:
   It's a pity that not all cases can be changed,  because some of them 
involvepublic api changes, such as `systemProperties`, `metricsProperties` and 
`classpathEntries`, define them to `collection.Seq` need change the following 
function:
   
   
https://github.com/apache/spark/blob/1af0a510202bdadfbc1ab6d04b47fe01a23f4555/core/src/main/scala/org/apache/spark/util/Utils.scala#L2811-L2814
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org