zhengruifeng commented on code in PR #39227: URL: https://github.com/apache/spark/pull/39227#discussion_r1057415979
########## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ########## @@ -691,6 +691,46 @@ class SparkConnectPlanner(session: SparkSession) { } Some(NthValue(children(0), children(1), ignoreNulls)) + case "window" if 2 <= fun.getArgumentsCount && fun.getArgumentsCount <= 4 => Review Comment: TimeWindow and SessionWindow do not have suitable constructor for the string parameters -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org