cloud-fan commented on code in PR #39248: URL: https://github.com/apache/spark/pull/39248#discussion_r1058114484
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedMutableProjection.scala: ########## @@ -36,18 +36,12 @@ class InterpretedMutableProjection(expressions: Seq[Expression]) extends Mutable this(bindReferences(expressions, inputSchema)) private[this] val subExprEliminationEnabled = SQLConf.get.subexpressionEliminationEnabled - private[this] lazy val runtime = - new SubExprEvaluationRuntime(SQLConf.get.subexpressionEliminationCacheMaxEntries) - private[this] val exprs = if (subExprEliminationEnabled) { - runtime.proxyExpressions(expressions) - } else { - expressions - } + private[this] val exprs = prepareExpressions(expressions, subExprEliminationEnabled) private[this] val buffer = new Array[Any](expressions.size) override def initialize(partitionIndex: Int): Unit = { - expressions.foreach(_.foreach { + exprs.foreach(_.foreach { Review Comment: This is a pre-existing bug. The final expressions we use is `exprs`, not `expressions` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org