dongjoon-hyun commented on code in PR #39280: URL: https://github.com/apache/spark/pull/39280#discussion_r1059223400
########## core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala: ########## @@ -102,6 +104,15 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl, val rpcEnv: Rp // Executors which are being decommissioned. Maps from executorId to ExecutorDecommissionInfo. protected val executorsPendingDecommission = new HashMap[String, ExecutorDecommissionInfo] + // Unknown Executors which are being decommissioned. This could be caused by unregistered executor + // This executor should be decommissioned after registration. + // Maps from executorId to (ExecutorDecommissionInfo, adjustTargetNumExecutors, + // triggeredByExecutor). + protected val unKnownExecutorsPendingDecommission = + CacheBuilder.newBuilder() + .maximumSize(1000) Review Comment: This looks like a random magic number. Do you mean that one `CoarseGrainedSchedulerBackend` can have many un-registered executors like `1000`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
