akpatnam25 commented on code in PR #38959: URL: https://github.com/apache/spark/pull/38959#discussion_r1063830324
########## common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java: ########## @@ -287,6 +288,9 @@ public void onFailure(Throwable e) { try { return result.get(timeoutMs, TimeUnit.MILLISECONDS); + } catch (TimeoutException e) { + logger.warn("RPC {} timed-out", rpcId); + throw Throwables.propagate(new SaslTimeoutException(e)); Review Comment: `RpcTimeoutException` in the core module and this is in common. Will just do: ``` throw Throwables.propagate(e.getCause()); ``` like the rest of the catches to avoid making it too complicated for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org