mridulm commented on code in PR #37922: URL: https://github.com/apache/spark/pull/37922#discussion_r1066433357
########## core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala: ########## @@ -366,8 +372,19 @@ class BlockManagerMasterEndpoint( } }.getOrElse(Seq.empty) + val removeShuffleMergeFromShuffleServicesFutures = + externalBlockStoreClient.map { shuffleClient => + mergerLocations.map { bmId => + Future[Boolean] { + shuffleClient.removeShuffleMerge(bmId.host, bmId.port, shuffleId, + RemoteBlockPushResolver.DELETE_ALL_MERGED_SHUFFLE) Review Comment: We already have this dependency - for example, `RemoteBlockPushResolver.MERGED_SHUFFLE*` in `BlockId` Initially I was going to propose moving this out - but given existing (internal) use, it looked fine for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org