mridulm commented on code in PR #37922: URL: https://github.com/apache/spark/pull/37922#discussion_r1068472060
########## common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java: ########## @@ -256,6 +256,22 @@ public void onFailure(Throwable e) { } } + @Override + public boolean removeShuffleMerge(String host, int port, int shuffleId, int shuffleMergeId) { + checkInit(); + try { + TransportClient client = clientFactory.createClient(host, port); + client.send( + new RemoveShuffleMerge(appId, comparableAppAttemptId, shuffleId, shuffleMergeId) Review Comment: Can you also add a `TODO` here (specufying the jira) ? Thx ########## common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java: ########## @@ -256,6 +256,22 @@ public void onFailure(Throwable e) { } } + @Override + public boolean removeShuffleMerge(String host, int port, int shuffleId, int shuffleMergeId) { + checkInit(); + try { + TransportClient client = clientFactory.createClient(host, port); + client.send( + new RemoveShuffleMerge(appId, comparableAppAttemptId, shuffleId, shuffleMergeId) Review Comment: Can you also add a `TODO` here (specifying the jira) ? Thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org