rednaxelafx commented on PR #39518: URL: https://github.com/apache/spark/pull/39518#issuecomment-1381033109
The fix sure works. I feel like polluting the `ExpressionProxy` into core expression implementation is unfortunate, but off the top of my head I don't have a better alternative suggestion (other than doing some refactorings to the `SubExprEvaluationRuntime` to avoid the root cause of the pollution) The nature of this would seem like a similar fix needs to be done for all of the expression types that have type-specific children (that are not flexibly typed as just `Expression`) -- these expression types would all have the same pattern of `withNewChildInternal` needing to do a type-cast, and you can always construct test cases to trigger the same type of issue. Should we fix all occurrences of such pattern, or deal with the root design issue in `SubExprEvaluationRuntime`? cc @cloud-fan @viirya -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
