[GitHub] [spark] panbingkun commented on pull request #39275: [SPARK-41759][CORE] Use `weakIntern` on string values in create new objects during deserialization

[GitBox]

panbingkun commented on PR #39275:
URL: https://github.com/apache/spark/pull/39275#issuecomment-1396852540

   > <img alt="image" width="645" 
src="https://user-images.githubusercontent.com/1097932/213345430-088ace51-e8ab-4f2b-9097-0184ab94efb8.png";>
   > 
   > @panbingkun there are 7 usages in from live entities, while there are 13 
usages in protobuf serializer..
   
   Base on rule: `a large number of` `duplicated strings with same value`; 
after refactor it, there are 18 usages in protobuf serializer, as follow:
   <img width="534" alt="image" 
src="https://user-images.githubusercontent.com/15246973/213434545-6ae184fe-a4c8-4929-9682-81b198dc409a.png";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org