[GitHub] [spark] panbingkun commented on a diff in pull request #39275: [SPARK-41759][CORE] Use `weakIntern` on string values in create new objects during deserialization

[GitBox]

panbingkun commented on code in PR #39275:
URL: https://github.com/apache/spark/pull/39275#discussion_r1081187372


##########
core/src/main/scala/org/apache/spark/status/protobuf/StageDataWrapperSerializer.scala:
##########
@@ -393,10 +393,8 @@ class StageDataWrapperSerializer extends 
ProtobufSerDe[StageDataWrapper] {
       getOptional(binary.hasFirstTaskLaunchedTime, () => new 
Date(binary.getFirstTaskLaunchedTime))
     val completionTime =
       getOptional(binary.hasCompletionTime, () => new 
Date(binary.getCompletionTime))
-    val failureReason =
-      getOptional(binary.hasFailureReason, () => 
weakIntern(binary.getFailureReason))
-    val description =
-      getOptional(binary.hasDescription, () => 
weakIntern(binary.getDescription))
+    val failureReason = getOptional(binary.hasFailureReason, 
binary.getFailureReason)

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org