srowen commented on code in PR #39660:
URL: https://github.com/apache/spark/pull/39660#discussion_r1083570242
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala:
##########
@@ -307,11 +307,12 @@ private[jdbc] class JDBCRDD(
""
}
+ val myTopExpression: String = dialect.getTopExpression(limit) // SQL
Server Limit alternative
Review Comment:
Oops yes I'm talking about what you're talking about, typo - MS SQL Server
I'm OK with it; the alternative is to somehow edit the SQL query down in the
MS SQL dialect maybe, I haven't thought about it. It'd be nicer but not sure
it's cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
