snmvaughan opened a new pull request, #39746:
URL: https://github.com/apache/spark/pull/39746

   ### What changes were proposed in this pull request?
   Update `SparkBuild.scala` to force SBT use of `protobuf-java` to match the 
Maven version.  The Maven dependencyManagement section forces `protobuf-java` 
to use `2.5.0`, but SBT is using `3.14.0`.
   
   ### Why are the changes needed?
   Define `protoVersion` in `SparkBuild.scala` and use it in 
`DependencyOverrides` to force the SBT version of `protobuf-java` to match the 
setting defined in the Maven top-level `pom.xml`.  Add comments to both 
`pom.xml` and `SparkBuild.scala` to ensure that the values are kept in sync. 
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Before the update, SBT reported using `3.14.0`:
   ```
   % build/sbt dependencyTree | grep proto | sed 's/^.*-com/com/' | sort | uniq 
-c
      8 com.google.protobuf:protobuf-java:2.5.0 (evicted by: 3.14.0)
     70 com.google.protobuf:protobuf-java:3.14.0
   ```
   
   After the patch is applied, SBT reports using `2.5.0`:
   ```
   % build/sbt dependencyTree | grep proto | sed 's/^.*-com/com/' | sort | uniq 
-c
     70 com.google.protobuf:protobuf-java:2.5.0
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to